As with all software, when you begin using it, you find out things that you should and shouldn't do.
NULL arguments to functions - check for each function:
mpz_get_str() is a function which seems to handle a NULL first argument just fine.
Example function call:
outM = mpz_get_str(NULL,10,M);
(outM above is a char pointer and gets the decimal representation of mpz M)
In the documentation, the function signature for mpz_get_str() is given as:
char * mpz_get_str (char *str, int base, mpz_t op )
Second example - be careful what you assume!
if (mpz_mod_ui(NULL,C,6) == 0) { /* do something */ }
The above throws a runtime error - not surprising when you consult the documentation for the function signature.
unsigned long int mpz_mod_ui (mpz_t r, mpz_t n, unsigned long int d )
mpz_mod_ui() is quite clear that the first argument should be an mpz type, so don't disappoint it :)
When working with gmp, you are effectively working in two type spaces - C and native gmp types. Functions such as mpz_mod_ui() are really flexible, in that they give you the mod() result in two different type spaces.
Libraries are not mind readers, and cannot know in which type space your next line of code will be working. By giving you the result as both an unsigned long int and the mpz_t labeled here as r, the function is doing it's damnedest to help you out!
The downside is that you may well see little point in retaining the result in the other type space.
My runtime error was caused by me attempting to throw away the mpz_t result as it felt redundant.
Here is my new preferred way - use an mpz_t you set up particularly for transient results.
if (mpz_mod_ui(MOD_NULL,C,6) == 0) {
/* flag as six multiple */
}
Just create your own mpz_t MOD_NULL and use it where you are not interested in keeping the result. You will need to run mpz_init(MOD_NULL) before executing the if statement illustrated.
Transient variables - bad coding practices to avoid:
In the past, I have been tempted to reuse spare variables - example:
if (mpz_mod_ui(BSQR,C,6) == 0) {
It is bad coding practice to use a seemingly proper variable, as a holder for transient data / as a dump.
Using dump variables generally is not without issue, however naming the thing correctly is at least a step in the right direction :)
The important thing to remember is that whatever you call your transient variable, that it is not used to hold values that really are used in your logic.
Avoid the temptation to reuse a label wherever possible - it rarely leads to good things.
NULL as the first argument to mpz_get_str - probably going wrong here:
Earlier I used mpz_get_str() as an example of a function that worked with NULL as a first argument.
outBSQRM4AC = mpz_get_str(NULL,10,BSQRM4AC);
Knowing the function signature, and looking at the above line of code, you should be thinking char pointer for outBSQRM4AC.
Assigning the result of mpz_get_str() using an equals symbol is okay, and you are asking the gmp library to do your allocation for you.
If however, you known the maximum size of the MPZ / character array that you require, then you may prefer to predefine your character array, and tell mpz_get_str() to use it. In that case the the first argument of mpz_get_str() will not be NULL.
If you have predefined your character array (including size, then you might instead be using a call of this form:
mpz_get_str(outBSQRM4AC,10,BSQRM4AC);
Notes and Further Reading:
The publisher SAMS have a book "Teach yourself C in 24 hours"
In the Chapter "Hour 17 - Allocating Memory" there is a discussion about malloc() and free() and how to use them in conjunction with character pointers.
A more indepth volume is titled "Teach yourself C in 21 days", but it really depends on how far you want to take your C skills, as to which is the better option.
Neither of these books are particularly 'new', however that is one of the plus points of C, it has a stable api and a body of literature that never goes out of date.
Neither of these books will teach you C++, however I have not and probably never will have, any interest in learning C++
If you do, then the 'in 24 hours', probably does not come near to describing, the time that you will have to devote to becoming skilled in C++.
Better C++ literature is available, if you decide ANSI C is not where you wish to spend your time.
